Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Surface viewer #4

Open
AntoineDao opened this issue Mar 31, 2019 · 7 comments
Open

Add Surface viewer #4

AntoineDao opened this issue Mar 31, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@AntoineDao
Copy link
Member

Add a small bit of UI that facilitates viewing details/data about highlights or clicked on surfaces.

@AntoineDao AntoineDao added the enhancement New feature or request label Mar 31, 2019
@theo-armour
Copy link
Member

theo-armour commented Mar 31, 2019

@AntoineDao

Code looks amazing / everything re-factored.

Will start having a look - and commenting - in a few hours.

Bravo!

@AntoineDao
Copy link
Member Author

Yeah it's quite different to the previous setup. The core package contains most of the ThreeJS / gbxml parsing code, whereas this is a react project. I'm happy to have a chat on slack or whatnot about react/webpack and co if it's not something you've come across before so you can have a proper play with it 😄

@theo-armour
Copy link
Member

@AntoineDao

All good. And it might also be fun to see/meet each other. Are you on Google Hangouts or something?

@AntoineDao
Copy link
Member Author

Aye indeed. I can do hangout or slack or what not. Shall we organise ourselves on slack or the forum?

@theo-armour
Copy link
Member

@AntoineDao

Good to close?

@AntoineDao
Copy link
Member Author

Nope. Haven't started on this at all.

@theo-armour
Copy link
Member

@AntoineDao

Oh, I'm sorry I cluttered this issue.

My bad, I thought https://www.ladybug.tools/spider-react/ was what you were referring to and therefore the issue had been dealt with. Now reading more carefully, I see you want to add more interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants