Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverless installs into a default namespace. why ? #545

Closed
ptesny opened this issue Jan 3, 2024 · 6 comments
Closed

serverless installs into a default namespace. why ? #545

ptesny opened this issue Jan 3, 2024 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ptesny
Copy link

ptesny commented Jan 3, 2024

Description

serverless installs into a default namespace

Expected result

serverless installs into a kyma-system namespace

Actual result

serverless installs into a default namespace

Steps to reproduce
create a gardener cluster with the required shoot extensions
install OS kyma and then istion and api-gateway modules.

install serverless module

$ make serverless-deploy
kubectl create ns kyma-system --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml --dry-run=client -o yaml | kubectl apply --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml -f -
namespace/kyma-system configured
kubectl label namespace kyma-system istio-injection=enabled --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml
namespace/kyma-system labeled

kubectl apply -f https://github.com/kyma-project/serverless-manager/releases/latest/download/serverless-operator.yaml --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml

customresourcedefinition.apiextensions.k8s.io/serverlesses.operator.kyma-project.io created
serviceaccount/serverless-operator created
clusterrole.rbac.authorization.k8s.io/serverless-operator-role created
clusterrolebinding.rbac.authorization.k8s.io/serverless-operator-rolebinding created
configmap/serverless-operator.kyma-project.io created
deployment.apps/serverless-operator created

kubectl apply -f https://github.com/kyma-project/serverless-manager/releases/latest/download/default-serverless-cr.yaml --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml

serverless.operator.kyma-project.io/default created

Troubleshooting

@kwiatekus
Copy link
Contributor

@ptesny please adjust the line

kubectl apply -f https://github.com/kyma-project/serverless-manager/releases/latest/download/default-serverless-cr.yaml --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml

to

kubectl apply -f https://github.com/kyma-project/serverless-manager/releases/latest/download/default-serverless-cr.yaml --kubeconfig ~/.kube/kubeconfig--kyma--btp.yaml -n kyma-system

@ptesny
Copy link
Author

ptesny commented Jan 4, 2024 via email

@kwiatekus kwiatekus added the kind/bug Categorizes issue or PR as related to a bug. label Jan 8, 2024
@Cortey
Copy link
Contributor

Cortey commented Jan 10, 2024

Hi, the true value that kustomize uses is stored here https://github.com/kyma-project/serverless/blob/main/config/operator/default/kustomization.yaml , It's not a typo. Regarding the instruction good call, i will update the readme.md

@ptesny
Copy link
Author

ptesny commented Jan 11, 2024

OK. so why the serverless module resources do not end up in kyma-system ?
Getting serverless in the default namespace is not good practice.
Other kyma modules do install to kyma-system
Thank you

@kwiatekus
Copy link
Contributor

The latest version of readme explains that serverless CR should be applied in kyma system namespace
https://github.com/kyma-project/serverless?tab=readme-ov-file#install

Other kyma modules ( istio, api-gateway ) do not have namespace scoped module CRs.
Serverless CR is namespace scoped and it installs in the same namespace where the CR is placed.

@kwiatekus
Copy link
Contributor

kyma-project/community#868 recommends to use static kyma-system namespace.
So there will be a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants