Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIM should validate relevant parts of the shoot spec when Runtime CR is updated #208

Closed
3 of 4 tasks
Tracked by #112
Disper opened this issue May 10, 2024 · 3 comments
Closed
3 of 4 tasks
Tracked by #112

Comments

@Disper
Copy link
Member

Disper commented May 10, 2024

Description
Some fields in Shoot-Spec could be updated independent to the RuntimeCR (e.g. update of Kubernetes images etc.).

We have to agree and implement a strategy how we deal with such cases, also considering if a change to an immutable field (of Shoot-Spec) would be required.

AC:

  • Validation. Agree on a strategy how we deal with changes applied on the Shoot-Spec (e.g. Deny modifications to particular fields in Shoot-Spec CR if some values were modified by Gardener, Sync back Shoot-Spec changes to Runtime CR etc. etc.) (e.g. using webhook)
    • Verify the available approaches with it's Pros / Cons and prepare a recommendation for the strategy
    • Share and agree the strategy within the team
    • Should not allow improper modification
@Disper
Copy link
Member Author

Disper commented Jun 13, 2024

Connected to #198

@Disper
Copy link
Member Author

Disper commented Jun 20, 2024

Extracted the actual upgrade (without validation) to a separate issue #270

@Disper Disper changed the title KIM should update relevant parts of the shoot spec when Runtime CR is updated KIM should validate relevant parts of the shoot spec when Runtime CR is updated Jun 20, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Jul 22, 2024

Duplicate of #232

@tobiscr tobiscr marked this as a duplicate of #232 Jul 22, 2024
@tobiscr tobiscr closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants