Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit metrics (of kubeconfig-rotation) collected only to those that are essential #179

Open
Disper opened this issue Apr 16, 2024 · 3 comments
Labels
area/control-plane Related to all activities around Kyma Control Plane

Comments

@Disper
Copy link
Member

Disper commented Apr 16, 2024

Description
Some of the collected metrics are or might not be essential:

  • expires (timestamp) label (as it is redundant because it's stored also as value)
  • rotate after (seconds) - align with SRE if this property is needed
  • expires (seconds)- align with SRE if this property is needed

Reasons

Having too many metrics might greatly increase the cost of storing the metrics.

Attachments

@Disper Disper added kind/feature Categorizes issue or PR as related to a new feature. area/control-plane Related to all activities around Kyma Control Plane labels Apr 16, 2024
@Disper
Copy link
Member Author

Disper commented Apr 16, 2024

While working on this issue, consider if something from #180 could also be done.

@atisap
Copy link

atisap commented May 10, 2024

  • Removing the label, called expires will decrease the churn rate, I would suggest that.
  • expires (seconds) which is the expirationDuration label could useful, because it is different on dev stage and prod environment, and we could check with that label if the expiration time reached the expirationDuration time. A good indicator to check if the kubeconfig not expired in time, probably because not rotated.
  • Regarding the rotate after (seconds) which is the rotationDuration label, an alert can be build to check if the expires time went beyond the rotationDuration, which mean the rotation not happened in time.
    As I see, the rotationDuration is the 40% of the expirationDuration on all environments. During building an alert, this result can reach without the rotationDuration by a simple calculation. The alerts are in progress, so can't state that this label not needed right now, but I will update the ticket.

@tobiscr tobiscr removed the kind/feature Categorizes issue or PR as related to a new feature. label Jun 26, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Oct 15, 2024

Relates as well to #113

@tobiscr tobiscr changed the title Limit metrics collected only to those that are essential Limit metrics (of kubeconfig-rotation) collected only to those that are essential Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane
Projects
None yet
Development

No branches or pull requests

3 participants