Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set force-deletion flag when creating shoot-cluster [KIM/feature] #103

Closed
1 task
Tracked by #112
tobiscr opened this issue Dec 15, 2023 · 7 comments
Closed
1 task
Tracked by #112

Set force-deletion flag when creating shoot-cluster [KIM/feature] #103

tobiscr opened this issue Dec 15, 2023 · 7 comments
Assignees
Labels
area/control-plane Related to all activities around Kyma Control Plane bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tobiscr
Copy link
Contributor

tobiscr commented Dec 15, 2023

Description

Gardner supports now the option to force the deletion of a cluster (which avoids longer waiting-periods during the de-provisioning e.g. the K8s cluster couldn't be gracefully stopped caused by hanging finalizers).

We agreed to use this feature flag and the infrastructure manager / provisioner should set this flag properly.

AC:

  • The annotation confirmation.gardener.cloud/force-deletion is set in the shoot-specs of Gardener clusters.

Reasons

Enable/accept non-graceful shutdowns of Gardener clusters to avoid longer waiting periods during the de-provisioning.

Attachments

[Moved from Provisioner to KIM]

@tobiscr tobiscr added kind/feature Categorizes issue or PR as related to a new feature. area/control-plane Related to all activities around Kyma Control Plane labels Dec 15, 2023
@tobiscr tobiscr changed the title [KIM] Set force-deletion flag when creating shoot-cluster Set force-deletion flag when creating shoot-cluster Dec 18, 2023
@tobiscr tobiscr added bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) bv/reliability Business Value: Reliability (see ISO 25010) and removed bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) bv/reliability Business Value: Reliability (see ISO 25010) kind/feature Categorizes issue or PR as related to a new feature. labels Dec 18, 2023
@tobiscr tobiscr added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 29, 2023
@tobiscr
Copy link
Contributor Author

tobiscr commented Mar 12, 2024

Pre-requisite for kyma-project/kyma#18198

@tobiscr tobiscr changed the title Set force-deletion flag when creating shoot-cluster Set force-deletion flag when creating shoot-cluster [KIM/feature] Jun 26, 2024
@Disper
Copy link
Member

Disper commented Jul 26, 2024

@tobiscr should that annotation be set for only new clusters or should also existing clusters be migrated at some point?
E.g. should the migrator also add that annotation to the Runtime CRs it creates?

@Disper Disper self-assigned this Jul 26, 2024
@Disper
Copy link
Member

Disper commented Jul 26, 2024

Confirmed that we want to set it only for new clusters.

@Disper
Copy link
Member

Disper commented Jul 26, 2024

According to what I've tried - it's not possible to just create a cluster with that annotation set.

This is only possible if the Shoot fails to be deleted normally.

For more details, please refer to the relevant Gardener docu.

It could be possible to do it differently and when we fail to delete a cluster with one of those listed error messages to apply the annotation then.

@tobiscr
Copy link
Contributor Author

tobiscr commented Jul 29, 2024

JFYI - @pbochynski :

After deeper investigation, we realised that this features collides with #126 :

  • The deletion flag becomes obsolete when we support the hibernation of clusters as save-deletion-approach
  • We recommend to postpone this feature until we have Safe deletion of Kyma Clusters [EPIC] #126 implemented. For the house-keeping we can still consider the force-deletion option.

@pbochynski
Copy link
Contributor

Yes - we can postpone this one. We should also check how Gardener handles the deletion of hibernated clusters. Maybe the force-deletion annotation will help to reduce the time.

@tobiscr
Copy link
Contributor Author

tobiscr commented Jul 30, 2024

We will for now not work on it, until we discovered how hibernation works. Possible that we can reuse this flag for deleting hibernated clusters faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants