This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Integration with rafter #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pPrecel
added
kind/feature
pPrecel
requested review from
adamwalach,
jasiu001,
mszostok,
piotrmiskiewicz,
PK85 and
polskikiel
as code owners
|
|
aerfio
reviewed
Nov 26, 2019
|
Please do not remove the old implementation, just create a new one. All implementations (also DummyProvider) implements the same interface. Then implement a feature flag (for example a field in config.ControllerConfig) which controls which implementation must be used. |
jasiu001
reviewed
Dec 9, 2019
jasiu001
reviewed
Dec 9, 2019
jasiu001
reviewed
Dec 9, 2019
pPrecel
requested review from
alexandra-simeonova,
bszwarc,
kazydek,
klaudiagrz,
majakurcius,
mmitoraj and
tomekpapiernik
as code owners
|
/test all |
jasiu001
approved these changes
Dec 9, 2019
pPrecel
removed
the
area/core-and-supporting
kazydek
approved these changes
Dec 9, 2019
hudymi
approved these changes
Dec 9, 2019
aerfio
suggested changes
Dec 11, 2019
aerfio
approved these changes
Dec 11, 2019
Co-Authored-By: Mateusz Puczyński <mati6095@gmail.com>
|
/test all |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Issue #6311