Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIRule controller discovers default domain #524

Closed
9 tasks done
Tracked by #130
strekm opened this issue Sep 15, 2023 · 1 comment
Closed
9 tasks done
Tracked by #130

APIRule controller discovers default domain #524

strekm opened this issue Sep 15, 2023 · 1 comment
Assignees
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@strekm
Copy link
Contributor

strekm commented Sep 15, 2023

Description

In component setup of Kyma there's global helm override representing default domain that can be used for setting up APIRule CR. In modular Kyma there's no such thing as global overrides and each module should discover configurations.
APIRule controller should discover default domain from Kyma default gateway. Atm Kyma default gateway is created by Istio module. So APIRule controller can assume that there's always "default" domain present and it can be retrieved from default Kyma gateway.
Default domain should be reconciled in standard reconcile loops (create, update, time based), which means that change should happen on existing APIRules.

ACs:

  • APIRule controller discovers domain
  • documentation
  • global.domainName removed from APIRule controller

PR

Reasons

modularisation

DoD:

  • provide documentation
    - [ ] release notes and What's New updates for Kyma customers
  • provide unit tests
  • test on production-like environment
    - [ ] verify resource limits
  • followup issue
    - [ ] create release and bump in kyma
  • PR reviewer will verify code coverage and evaluate if it is acceptable

Attachments

part of: #130

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/api-gateway Issues or PRs related to api-gateway labels Sep 15, 2023
@strekm strekm added this to the 2.0 milestone Sep 15, 2023
@strekm
Copy link
Contributor Author

strekm commented Sep 15, 2023

#515

@barchw barchw assigned nataliasitko and unassigned triffer Sep 15, 2023
@strekm strekm mentioned this issue Sep 15, 2023
28 tasks
@nataliasitko nataliasitko removed their assignment Sep 18, 2023
@barchw barchw self-assigned this Sep 19, 2023
@strekm strekm closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants