Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIGateway v1alpha1 proposal #473

Closed
5 tasks done
Tracked by #130
strekm opened this issue Aug 24, 2023 · 1 comment
Closed
5 tasks done
Tracked by #130

APIGateway v1alpha1 proposal #473

strekm opened this issue Aug 24, 2023 · 1 comment
Assignees
Labels
area/api-gateway Issues or PRs related to api-gateway documentation Improvements or additions to documentation kind/feature Categorizes issue or PR as related to a new feature.

Comments

@strekm
Copy link
Contributor

strekm commented Aug 24, 2023

Description

Create document (docs/contributor) that will describe proposed API to configure api-gateway manager. Responsibility of api-gateway manager will be:

  • installation of api-gateway controller that manages APIRule CRD
  • managing of gateway(s) - default kyma-gateway and in the future other gateways too
  • managing certificates for above gateways
  • managing domains for istio ingress gateway IP (including default kyma domain)
  • installation of ORY oathkeeper (this component will not be a part of api-gateway in the future)
    Since ORY Hydra is deprecated and will be removed from Kyma in version 2.19, Hydra should not be a part of API proposal nor implementation.

Take into consideration api-gateway profile settings and overrides created for managed Kyma.

At this moment default Kyma domain is set up by Istio operator by annotating Istio ingress gateway service with gardener specific annotations. This responsibility will be passed to api-gateway module. instead of annotating ingress gateway service DNSEntry should be created. Users should be able to specify their domains for DNSEntry.

api-gateway module has strong dependency to Istio, Gardener DNS management and Gardener Certificates management.

ACs:

  • APIGateway v1alpha1 proposal documented: spec and status
  • proposal approved by @kyma-project/goat
  • proposal approved by @pbochynski

Decision needed:

  • should we expose ORY oathkeeper configuration -> any related configuration will not be exposed in api-gateway module API

Reasons

DoD:

  • provide documentation
    - [ ] release notes and What's New updates for Kyma customers
    - [ ] provide unit tests
    - [ ] provide integration tests
    - [ ] test on production-like environment
    - [ ] verify resource limits
    - [ ] followup issue
    - [ ] create release and bump in kyma
    - [ ] PR reviewer will verify code coverage and evaluate if it is acceptable

Attachments

Proposal PR

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/api-gateway Issues or PRs related to api-gateway documentation Improvements or additions to documentation labels Aug 24, 2023
@strekm strekm mentioned this issue Aug 3, 2023
28 tasks
@pbochynski
Copy link
Contributor

Oathkeeper will be removed soon and can be already replaced by istio/envoy so I would not expose it to the user.

@barchw barchw assigned barchw and unassigned barchw Aug 25, 2023
@barchw barchw self-assigned this Sep 8, 2023
@strekm strekm closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway documentation Improvements or additions to documentation kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants