From 09f9b57c64cb3946c89afd25925dea5893533985 Mon Sep 17 00:00:00 2001 From: Kyle Barron Date: Sun, 6 Mar 2022 19:46:00 -0700 Subject: [PATCH] A couple suggestions from clippy --- src/lib.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index f3491e4f..80f0fb6d 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,7 +14,6 @@ use arrow2::io::parquet::write::{ }; use std::io::Cursor; -use wasm_bindgen; use wasm_bindgen::prelude::*; // A macro to provide `println!(..)`-style syntax for `console.log` logging. @@ -77,7 +76,7 @@ pub fn read_parquet(parquet_file: &[u8]) -> Result { Err(error) => return Err(JsValue::from_str(format!("{}", error).as_str())), }; - return Ok(unsafe { Uint8Array::view(&output_file) }); + Ok(unsafe { Uint8Array::view(&output_file) }) } #[wasm_bindgen(js_name = writeParquet)] @@ -134,6 +133,8 @@ pub fn write_parquet(arrow_file: &[u8]) -> Result { encodings, ); + // TODO: from clippy: + // for loop over `row_groups`, which is a `Result`. This is more readably written as an `if let` statement for group in row_groups { for maybe_column in group { let column = match maybe_column { @@ -151,7 +152,7 @@ pub fn write_parquet(arrow_file: &[u8]) -> Result { } let _size = parquet_writer.end(None); - return Ok(unsafe { Uint8Array::view(&output_file) }); + Ok(unsafe { Uint8Array::view(&output_file) }) } #[wasm_bindgen(js_name = setPanicHook)]