Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code into lower-level functions, use ? operator #25

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Refactor code into lower-level functions, use ? operator #25

merged 2 commits into from
Mar 11, 2022

Conversation

kylebarron
Copy link
Owner

Slowly looking more like (what I imagine to be) idiomatic Rust

  • Refactors the bloated high-level functions into lower level functions that return Result<Vec<u8>, parquet::errors::ParquetError> or Result<Vec<u8>, arrow2::error::ArrowError>.
  • Use the ? operator in each read/write function for better conciseness
  • Feature gated top-level imports

Resolves most of #24

@kylebarron kylebarron merged commit 6663d8d into main Mar 11, 2022
@kylebarron kylebarron deleted the refactor-functions branch March 11, 2022 07:21
This was referenced Mar 12, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylebarron