Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper v2 support #113

Open
22a opened this issue Jan 31, 2020 · 4 comments
Open

Popper v2 support #113

22a opened this issue Jan 31, 2020 · 4 comments

Comments

@22a
Copy link

22a commented Jan 31, 2020

Popper v2 was officially released a week or two ago. I'm just opening this as a tracking issue to see if/when ember-popper would support it.

@lolmaus
Copy link

lolmaus commented Feb 20, 2020

Yes please!

@alexlafroscia
Copy link

In case you're interested in something a little different -- or a path to this addon supporting Popper V2 -- I am working on a modifier-based Ember addon for Popper here:

https://github.com/alexlafroscia/ember-popper-modifier

@pzubar
Copy link

pzubar commented Jul 28, 2022

Hello! I've decided to try to update the addon's code to support the Popper v2.

Ember-popper is used under the hood of a great ember-attacher package so I thought it would be great to update it afterwards as well (cc @tylerturdenpants).

I am new to ember addons, so I would be glad to see the review comments if possible. What do you think, @kybishop @simonihmig @pzuraq? Thank you in advance!

P. S. I could possibly try to migrate the package code to use https://github.com/floating-ui/floating-ui afterwards that is kinda "Popper v3" (Floating UI is a new Popper name) and seems to be even smaller than Popper v2 🤔

@simonihmig
Copy link
Collaborator

I have stopped using this addon a while ago, so I will not be able to do any maintenance/review work here as I did before (to some small extent). Tbh not sure if this addon is still considered actively maintained, and by whom? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants