Use RAF for animations #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73f2c3c.
kybishop
force-pushed
the
use-RAF-for-animations
branch
from
14a9179
to
00733e0
Compare
kybishop
force-pushed
the
use-RAF-for-animations
branch
from
00733e0
to
b705c22
Compare
|
Testing a component that uses Will have to dig into why the 2.12 tests are failing. |
|
Merging this and fixing tests later. There's no reason this would break things in prior versions of ember, we're just hitting limitations of the test framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things buttery smooth by greatly improving performance. It also fixes, once and for all, strange positioning issues that spur from
display: nonebeing toggled on the same repaint that animations take place.