[Question] Ability to have a monthly preview build on Docker Hub

[fly-man-]

Would it be possible to have a monthly preview build on Docker Hub, the preview build is already 3 months old and I presume there's new updates that can be tested by end-users ?

[kvalev]

Generally a new preview image is created every time a pull request has been merged. Meaning there were no updates/PRs in the last couple of months for few reasons:

• I have implemented almost everything that I was missing in the upstream project (there are few things planned, but none of them are very important, so I am not in a hurry)
• The newly implemented multi-user support in the upstream project is, from my point of view, a clear regression compared to the old implementation, which had support for multiple user accounts and which is something I personally am heavily using for friends and family. So, as of now I dont have plans to fast-forward my fork...

Are you missing any particular feature?

[fly-man-]

#96 and #17 look ready to be merged into preview, those are the 2 pieces I would like my end-users to be able to test

[kvalev]

Thanks for reminding me, I forgot about those. Will try to get them merged in the next few days.

[fly-man-]

Any progress on this ?

[rickysarraf]

Are you missing any particular feature?

Hello @kvalev Happy New Year 2023 🎉

Maybe a bit offtopic, but does sharing work for you with self-signed certificates on Chrome browser ?

[rickysarraf]

And similar thing on Chromium.

If it makes any relevance, I have thumbnails above 720 px disabled and rely entirely on Dynamic Previews

[rickysarraf]

Going by the code, onDownload() should fail. But that works proper.

    onDownload() {
      this.onPause();
      if (!this.item || !this.item.DownloadUrl) {
        console.warn("photo viewer: no download url");
        return;
      }
      Notify.success(this.$gettext("Downloading…"));
      new Photo().find(this.item.UID).then(p => p.downloadAll());
    },
    onWebShare() {
      this.onPause();
      if (!this.item || !this.item.download_url) {
        console.warn("photo viewer: no download url");
        return;
      }
      new Photo().find(this.item.uid).then(p => p.webShare()).catch(e => {
        this.$notify.error("couldn't share photo");
        console.warn(e);
      });
      Notify.success(this.$gettext("Downloading & Sharing…"));
    },

[kvalev]

I just tried it on my local instance and its broken there as well. Thanks for finding it. I just briefly looked into the code, I have a suspicion, maybe you can test it for me, as I need to setup my environment from scratch. Can you change item.download_url in the onWebShare method to item.DownloadUrl (similar to the download method). If this was the problem that would be a bit embarrassing, but at least easy to fix.

[rickysarraf]

After applying the suggested change, I get the following error upon click on Share

websocket: connected app.20dfab2692c0c33d33a2.js:2:3289414
Uncaught (in promise) DOMException: The fetching process for the media resource was aborted by the user agent at the user's request. 4
XHRGEThttps://private.researchut.com:4430/api/v1/photos
[HTTP/2 400 Bad Request 9ms]

	
GET
	https://private.researchut.com:4430/api/v1/photos
Status
400
Bad Request
VersionHTTP/2
Transferred300 B (38 B size)
Referrer Policystrict-origin-when-cross-origin
Request PriorityHighest

Object { message: "Request failed with status code 400", name: "AxiosError", code: "ERR_BAD_REQUEST", config: {…}, request: XMLHttpRequest, response: {…}, stack: "" }
app.20dfab2692c0c33d33a2.js:2:2077919
Object { message: "Request failed with status code 400", name: "AxiosError", code: "ERR_BAD_REQUEST", config: {…}, request: XMLHttpRequest, response: {…}, stack: "" }
app.20dfab2692c0c33d33a2.js:2:3356792

websocket: connected app.20dfab2692c0c33d33a2.js:2:3289414
Uncaught (in promise) DOMException: The fetching process for the media resource was aborted by the user agent at the user's request. 4
XHRGEThttps://private.researchut.com:4430/api/v1/photos
[HTTP/2 400 Bad Request 9ms]

[kvalev]

@rickysarraf I was going through my notifications and found this one. I fixed the problem few days ago in this PR, let me know if the issue still persists.

[fly-man-]

Hope you haven't forgotten about the open PR's #96 and #17

[kvalev]

#96 is merged and should be part of the preview release and while #17 has not been merged yet, a random sort has been added to the search page, which kinda makes the PR obsolete.