-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash function improvements #2290
Comments
Changing the integer hash is straightforward, but there are some major remaining questions:
|
Simple answer is yes: #2952. Also, I think this issue was already more or less implemented in 359c09d, so maybe this could be closed after #2952 is merged. |
Yes, integer hashing was changed by me. String hashing, seems like you have a PR for. I think the other hash functions are defined in terms of those two. |
Currently, our hash function is quite naive, and it's very easy to cause very bad collisions in the hash index.
We should replace it. DuckDB seems to be using a very simple but efficient hash function, which seems to be a good choice based on some cursory reading online.
We should also change the name since we aren't actually using murmurhash.
The text was updated successfully, but these errors were encountered: