Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider moving hsd & hs-client to "peerDependencies" #23

Open
pinheadmz opened this issue Oct 15, 2021 · 1 comment
Open

consider moving hsd & hs-client to "peerDependencies" #23

pinheadmz opened this issue Oct 15, 2021 · 1 comment

Comments

@pinheadmz
Copy link
Collaborator

pinheadmz commented Oct 15, 2021

...or updating to latest:

hsd@3.0.0

hs-client@0.0.10

This is just to avoid duplicates with all their native node addons n shit when installing Bob Wallet

Actually, since we dont use semver in Bob any version you set in Shakedex will trigger a duplicate download. So I think peer dep is probably best? I don't know if matching the commit hash would work the same way:

    "hs-client": "https://github.com/handshake-org/hs-client/tarball/61aaf060a473b496b85501d795e586b9217d3306",
    "hsd": "https://github.com/handshake-org/hsd/tarball/27745128b3d8f5dd72b4cfbc933e14a1029dbe18",
@pinheadmz
Copy link
Collaborator Author

Actually, should be as easy as:

-    "hs-client": "0.0.9",
-    "hsd": "https://github.com/handshake-org/hsd/tarball/a94ce87",
+    "hs-client": "^0.0.10",
+    "hsd": "^3.0.1",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant