Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: the develop branch of feedparser does not work with current version of libxml2 (2.13.3) #470

Closed
maksverver opened this issue Aug 29, 2024 · 1 comment

Comments

@maksverver
Copy link
Contributor

To make a long story short, I discovered that the develop branch of feedparser does not work with the current release of libxml2. More discussion is here: lemon24/reader#350

This is problematic because feedparser explicitly prefers using the libxml2 driver, if available:

PREFERRED_XML_PARSERS = ["drv_libxml2"]

The master branch (which corresponds to the current release) does not have this problem, as it always callssource.setByteStream() and never source.setByteStream():

source.setByteStream(io.BytesIO(data))

I tracked the cause down to libxml2's handling of text streams (instead of binary streams) and filed an issue upstream here: https://gitlab.gnome.org/GNOME/libxml2/-/issues/790. Fortunately this issue was promptly fixed! But the develop branch of feedparser should not be released until that fix in libxml2 has been released, because otherwise, feedparser won't work when libxml2 is installed.

@maksverver
Copy link
Contributor Author

To follow up: the bug fix was released in libxml2 v2.13.4, so I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant