Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py.typed is missing from current release on pypi #373

Closed
sbrudenell opened this issue Jun 6, 2023 · 2 comments
Closed

py.typed is missing from current release on pypi #373

sbrudenell opened this issue Jun 6, 2023 · 2 comments

Comments

@sbrudenell
Copy link

Given

import feedparser
feedparser.parse("test")

A straightforward type-check fails:

$ python3 -m venv v
$ source v/bin/activate
(v) $ pip install feedparser mypy
...
(v) $ mypy t.py
t.py:1: error: Skipping analyzing "feedparser": module is installed, but missing library stubs or py.typed marker  [import]
t.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)

I see py.typed is present in the source code. If I manually download the current *.whl from pypi, I do not see py.typed.

If I clone the repo locally and do pip install ., then I see py.typed in my venv and mypy type-checks the test file. (This also required pip install chardet types-requests for further typing dependencies)

If I do pip wheel . in a local clone, I do see py.typed in the *.whl.

Perhaps something is going wrong at a packaging step? I couldn't find any packaging/publishing workflow in the github actions config, so I can't diagnose further.

@kurtmckee
Copy link
Owner

Releases are created from the master branch (which will renamed to releases in the future).

When feedparser 7 is released it will include the py.typed file.

@eggplants
Copy link

Any update on next release? Latest master branch (32adbe1) is 236 commits behind develop branch (696d5b9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants