docs: added MADR for MeshRateLimit #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
lukidzi
added
the
ci/skip-test
lukidzi
changed the title
lahabana
reviewed
Nov 16, 2022
There was a problem hiding this comment.
Great start! I'd like us anticipate potentially having a global rate limit in this policy in the future.
Might be worth to have something like:
default:
local:
http: ...Also it might be useful to have a disabled flag to be potentially used when overriding defaults in child policy. I'm not sure how we'd do this other @lobkovilya interested in your opinion here.
|
Please reference the issue in this PR! |
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
lahabana
reviewed
Nov 18, 2022
Co-authored-by: Charly Molter <charly@molter.io> Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Co-authored-by: Charly Molter <charly@molter.io> Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
jakubdyszkiewicz
approved these changes
Nov 22, 2022
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
slonka
approved these changes
Nov 22, 2022
12 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?