Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(versions.sh): always use 9 characters short hash #5296

Merged
merged 2 commits into from
Nov 10, 2022
Merged

ci(versions.sh): always use 9 characters short hash #5296

merged 2 commits into from
Nov 10, 2022

Conversation

lahabana
Copy link
Contributor

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
ci(changelog): add dependabot rollup
b9c1c1b 
When there's multiple PRs with successive updates to the same dependency
this will roll them together in the changelog.

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
ci(versions.sh): always use 9 characters short hash
8d9c373 
This avoids git picking shorter hashes when it can and make it
easier to get a preview version from any commit

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner November 10, 2022 14:15
@lahabana lahabana mentioned this pull request Nov 10, 2022
Merged
@lahabana lahabana changed the title Fixed size version hash ci(versions.sh): always use 9 characters short hash Nov 10, 2022
@lahabana lahabana merged commit eb8738a into kumahq:master Nov 10, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
@lahabana lahabana deleted the fixedSizeVersionHash branch March 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahabana @jakubdyszkiewicz @bartsmykla