Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): override grafana plugin files by default #5208

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Oct 25, 2022

override grafana plugin files so the container does not crash loop on docker restart because the files already exist

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue -- no docs needed
  • Link to UI issue or PR -- not ui issue
  • Is the issue worked on linked? -- not reported, small fix
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- yes
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS -- yes
  • Unit Tests -- updated golden files
  • E2E Tests -- no need
  • Manual Universal Tests -- not universal issue
  • Manual Kubernetes Tests -- done via kubectl exec
  • Do you need to update UPGRADE.md? -- no
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? -- no

…crash loop on docker restart

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka requested a review from a team as a code owner October 25, 2022 08:07
@lahabana lahabana merged commit 6a019b2 into kumahq:master Oct 25, 2022
@lukidzi lukidzi changed the title fix(kumacp): override grafana plugin files by default fix(kuma-cp): override grafana plugin files by default Nov 3, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants