Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github): fix pr-comments action #5161

Merged
merged 2 commits into from
Oct 18, 2022
Merged

ci(.github): fix pr-comments action #5161

merged 2 commits into from
Oct 18, 2022

Conversation

lahabana
Copy link
Contributor

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
fix(.github): inline login var in pr-comments action
7c11cc2 
- For some reason we're not getting this as maintainer in the env var

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested a review from a team as a code owner October 18, 2022 08:31
@lahabana lahabana changed the title Fix comment action ci(.github): fix pr-comments action Oct 18, 2022
@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 18, 2022
@lahabana lahabana enabled auto-merge (squash) October 18, 2022 08:35
@lahabana lahabana merged commit 55406f7 into kumahq:master Oct 18, 2022
@slonka
Copy link
Contributor

slonka commented Oct 19, 2022

does this mean I'll be able to do /golden_files etc. now?

@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

Assignees
No one assigned
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahabana @slonka @lukidzi