From 1998ad0b45bb5c3253d39ddcd9c3ac2d2cf678a1 Mon Sep 17 00:00:00 2001 From: James Peach Date: Sat, 25 Sep 2021 01:09:10 +1000 Subject: [PATCH] fix(kuma-cp) remove insight update rate limit burst (#2825) The token burst that is configured for the insight update rate limit allows the update rate to burst up to 50 times before stabilizing to the desired rate. This would typically happen when kuma-cp starts up and all the dataplanes reconnect, which is precisely the time when you want the rate limit to apply for operational stability. Signed-off-by: James Peach (cherry picked from commit 13df4cfb3e448c47783ece9d16cb911867014a4f) --- pkg/insights/components.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/insights/components.go b/pkg/insights/components.go index 9a3826fd3de3..f7938a9c98eb 100644 --- a/pkg/insights/components.go +++ b/pkg/insights/components.go @@ -15,7 +15,7 @@ func Setup(rt runtime.Runtime) error { MinResyncTimeout: rt.Config().Metrics.Mesh.MinResyncTimeout, MaxResyncTimeout: rt.Config().Metrics.Mesh.MaxResyncTimeout, RateLimiterFactory: func() *rate.Limiter { - return rate.NewLimiter(rate.Every(rt.Config().Metrics.Mesh.MinResyncTimeout), 50) + return rate.NewLimiter(rate.Every(rt.Config().Metrics.Mesh.MinResyncTimeout), 0) }, Registry: registry.Global(), })