Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate XDS for Ingress Dataplane #776

Closed
jakubdyszkiewicz opened this issue May 26, 2020 · 1 comment
Closed

Generate XDS for Ingress Dataplane #776

jakubdyszkiewicz opened this issue May 26, 2020 · 1 comment

Comments

@jakubdyszkiewicz
Copy link
Contributor

Summary

Generate XDS for Ingress Dataplane.

Implementation tips:

I think the most suitable way to implement this is to provide implementation to this

type ResourceGenerator interface {
	Generate(xds_context.Context, *model.Proxy) ([]*model.Resource, error)
}

This will be a merge of InboundProxyGenerator and OutboundProxyGenerator.
Given such Ingress dataplane

type: Dataplane
mesh: default
name: ingress-1
networking:
  ingress: true # to decide: we need a marker that this is an ingress
  address: 1.1.1.4
  inbound:
  - port: 10000 # picked automatically
    tags:
      service: backend
      cluster: cluster-1
  - port: 10001 # picked automatically
    tags:
      service: backend
      version: v2
      cluster: cluster-1

We will open 2 inbound listeners, create 2 Envoy clusters. Each Envoy cluster will have corresponding EDS with endpoints for all DPs (inbounds) in a Kuma cluster.

@nickolaev
Copy link
Contributor

Fixed by #818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants