Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global/Local config infrastructure #766

Closed
nickolaev opened this issue May 22, 2020 · 5 comments · Fixed by #788
Closed

Global/Local config infrastructure #766

nickolaev opened this issue May 22, 2020 · 5 comments · Fixed by #788
Assignees

Comments

@nickolaev
Copy link
Contributor

nickolaev commented May 22, 2020

Summary

To support the Multi-cluster and Hybrid deployments as described in multicluster.md, the Kuma CP binary will be split functionally into a Global CP and Local CP. This issue is to provide the infrastructure, command-line flags, and the appropriate kumactl install mechanisms. No real functionality is envisioned here, rather this will enable project-wide configuration so that the following implementation can leverage the flash to enable/disable particular functionalities in the code.

This is a break down of the work we envision:

    command: ["kuma-cp"]
    args: {{ .KumaCPArgs }}

The Generate .KumaCPArgs dynamically based on the provided flags.

@nickolaev
Copy link
Contributor Author

@tharun208 please let me know if you need more information.

@tharun208
Copy link
Contributor

looks fine @nickolaev

@tharun208
Copy link
Contributor

tharun208 commented May 29, 2020

@nickolaev we also need to have a validation if the user tries to run kuma cp run with this own config file which has a different mode of cp rather than the specified one?

@nickolaev
Copy link
Contributor Author

Yes, and I assume the command line should take preference as it is explicit.
I was also thinking would --mode [standalone|local|global] make more sense than --standalone, --local, --global?

@tharun208
Copy link
Contributor

Yes, and I assume the command line should take preference as it is explicit.
I was also thinking would --mode [standalone|local|global] make more sense than --standalone, --local, --global?

yes, --mode more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants