-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global/Local config infrastructure #766
Comments
@tharun208 please let me know if you need more information. |
looks fine @nickolaev |
@nickolaev we also need to have a validation if the user tries to run |
Yes, and I assume the command line should take preference as it is explicit. |
yes, |
Summary
To support the Multi-cluster and Hybrid deployments as described in multicluster.md, the Kuma CP binary will be split functionally into a Global CP and Local CP. This issue is to provide the infrastructure, command-line flags, and the appropriate
kumactl install
mechanisms. No real functionality is envisioned here, rather this will enable project-wide configuration so that the following implementation can leverage the flash to enable/disable particular functionalities in the code.This is a break down of the work we envision:
have command line arguments to
kuma-cp run
. We want three modes--standalone
(which is the default if not specified)--local
and--global
.whatever is configured on the command line should be available in the global kuma-cp config as a flag: https://github.com/Kong/kuma/blob/master/pkg/config/app/kuma-cp/config.go#L88
We need a set of these to verify this works robustly
We shoudl be able to call
kumactl install control-plane --local
and it should generate ayaml
that invokes thekuma-cp run --local
. Essentially it is templetasing thisyaml
at this place: https://github.com/Kong/kuma/blob/master/app/kumactl/data/install/k8s/control-plane/kuma-cp/app.yaml#L90 and adding something like:The Generate
.KumaCPArgs
dynamically based on the provided flags.The text was updated successfully, but these errors were encountered: