Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer bootstrapParam.xdsHost #323

Closed
jakubdyszkiewicz opened this issue Oct 9, 2019 · 1 comment · Fixed by #449
Closed

Infer bootstrapParam.xdsHost #323

jakubdyszkiewicz opened this issue Oct 9, 2019 · 1 comment · Fixed by #449
Assignees
@jakubdyszkiewicz

Comments

@jakubdyszkiewicz
Copy link
Contributor

Summary

Once #315 is done, we will have config property of public facing Kuma hostname. This name should be used for BootstrapParamsConfig#XdsHost by default instead of localhost.

Connected issue #322
@yskopets
Copy link
Contributor

yskopets commented Oct 9, 2019

Just to clarify, in order to infer BootstrapParamsConfig#XdsHost we shouldn't make an HTTP request to the endpoint described in #315.

Instead, the value of a new configuration property that will be introduced as part of #315 should become the default value for BootstrapParamsConfig#XdsHost.

@jakubdyszkiewicz jakubdyszkiewicz mentioned this issue Nov 18, 2019
Merged
@jakubdyszkiewicz jakubdyszkiewicz self-assigned this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubdyszkiewicz jakubdyszkiewicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kuma-cp) autoconfigure xds params kumahq/kuma
2 participants
@jakubdyszkiewicz @yskopets