Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose metrics from k8s controller-runtime #2927

Closed
bartsmykla opened this issue Oct 8, 2021 · 8 comments · Fixed by #7158
Closed

Expose metrics from k8s controller-runtime #2927

bartsmykla opened this issue Oct 8, 2021 · 8 comments · Fixed by #7158
Labels
area/observability good first issue Good for newcomers kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@bartsmykla
Copy link
Contributor

bartsmykla commented Oct 8, 2021 •
edited by michaelbeaumont
Loading

This issue is a followup from @jakubdyszkiewicz question #2764 (comment)

Exposed metrics are listed in the kubebuilder docs

One important use case is information about the state of the pod admission webhook
@bartsmykla bartsmykla mentioned this issue Oct 8, 2021
Merged
6 tasks
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 23, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/stale Inactive for some time. It will be triaged again labels Jan 21, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 21, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@michaelbeaumont michaelbeaumont changed the title Investigate what kind of metrics we can get from k8s controller-runtime Expose metrics from k8s controller-runtime May 11, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 23, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 23, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Jun 24, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 25, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 25, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 24, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Oct 31, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@lahabana lahabana mentioned this issue Jun 8, 2023
Closed
@Automaat
Copy link
Contributor

This could be hard to do because all metrics are inside an internal package and not exposed for usage. Also there is open issue in controller-runtime about this. And another one closed where they ditched the topic: kubernetes-sigs/controller-runtime#1995

@jakubdyszkiewicz jakubdyszkiewicz mentioned this issue Jul 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/observability good first issue Good for newcomers kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(metrics): expose kube controller manager metrics jakubdyszkiewicz/kuma
6 participants
@lahabana @michaelbeaumont @slonka @Automaat @bartsmykla @lukidzi