Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDS optimizations #1468

Open
nickolaev opened this issue Jan 22, 2021 · 14 comments
Open

HDS optimizations #1468

nickolaev opened this issue Jan 22, 2021 · 14 comments
Assignees
@jakubdyszkiewicz
Labels
area/performance area/universal kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again

Comments

@nickolaev
Copy link
Contributor

If I understand this code, it means that for every interval (5s) we will be fetching the DP from the database (uncached).
Is there any other place in the code that modifies health? If not, we could store this data here in some map and update only if there is a change. Look at DataplaneStatusSink and DataplaneInsight, it updates only if there is a change in the insight.

Originally posted by @jakubdyszkiewicz in #1418 (comment)
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 24, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added area/universal triage/accepted The issue was reviewed and is complete enough to start working on it area/performance kind/improvement Improvement on an existing feature and removed triage/stale Inactive for some time. It will be triaged again labels Apr 26, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 27, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jun 29, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 29, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting and removed triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again labels Aug 29, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/needs-reproducing Someone else should try to reproduce this and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 7, 2022
@jakubdyszkiewicz jakubdyszkiewicz self-assigned this Sep 7, 2022
@jakubdyszkiewicz
Copy link
Contributor

Still an issue. We have a guard on update, but not on get.

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it triage/pending This issue will be looked at on the next triage meeting and removed triage/needs-reproducing Someone else should try to reproduce this triage/accepted The issue was reviewed and is complete enough to start working on it labels Oct 11, 2022
@kleinfreund kleinfreund added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 2, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Feb 1, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label May 8, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Aug 8, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz
Copy link
Contributor

We could wire in MeshContext to optimize this

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label May 20, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Aug 26, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Nov 25, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubdyszkiewicz jakubdyszkiewicz

Labels
area/performance area/universal kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@lahabana @nickolaev @slonka @jakubdyszkiewicz @kleinfreund @bartsmykla @lobkovilya @lukidzi