refactor: include preview.sh script into installer.sh #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleinfreund
changed the title
lahabana
reviewed
Nov 9, 2022
lahabana
approved these changes
Nov 10, 2022
Incorporates the logic from the preview.sh script into the installer.sh script. Changes the preview.sh script to use the installer.sh script directly with `VERSION=preview`. Sets the latest version for the dev docs to `preview` (was `2.0.0`). Fixes broken links to the Kubernetes documentation. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
|
Comment: Waiting with merging this until we’ve published the version Kong Mesh preview version with a 9 character hash. |
|
Comment: The first Kong Mesh preview version with a 9 character hash was published (e.g. https://download.konghq.com/mesh-alpine/kong-mesh-0.0.0-preview.v0d9c23609-ubuntu-amd64.tar.gz) so I’m merging this. |
|
@kleinfreund next time can you open a new PR to fix things like the service account links? It has nothing to do with the |
cloudjumpercat
pushed a commit
to Kong/docs.konghq.com
that referenced
this pull request
Nov 14, 2022
Changes the `REPO_PREFIX` argument to `REPO` following changes to the kuma.io/installer.sh changes made in kumahq/kuma-website#1149. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com> Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Guaris
added a commit
to Kong/docs.konghq.com
that referenced
this pull request
Nov 17, 2022
* Fix typo in `config.add.querystring` description (#4765) * chore(deps): update dependency jest to v29.3.1 * fix(deps): update dependency @segment/analytics-next to v1.46.0 * chore: uses REPO argument in installer.sh script (#4770) Changes the `REPO_PREFIX` argument to `REPO` following changes to the kuma.io/installer.sh changes made in kumahq/kuma-website#1149. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com> Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com> * Fix broken link checker (#4774) * docs(readme): add submodule update instructions jekyll expects files in src/.repos/kuma/* which are coming from a submodule. * kic: add translation failures troubleshooting section (#4779) * kic: add translation failures troubleshooting * Update troubleshooting.md * Fix Vale errors, copyedit Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Add uninstall instructions to Ubuntu (#4781) * uninstall instructions * spelling * formatting * Apply suggestions from code review Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> * [DOCU-1924] New "Manage decK with Docker" page (#4124) * Add Docker image page * Add new page * Apply suggestions from code review Co-authored-by: Angel <Guaris@users.noreply.github.com> * Rename file, move to new nav file, minor copyedits Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Move location in nav Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Fix broken link Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Make link to doc version specific Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Apply feedback, fix blank lines in nav file Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Backport doc to prior releases Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Remove from pre-1.7 nav Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> Co-authored-by: Angel <Guaris@users.noreply.github.com> Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> * Plugin template: Update and add sample versions file (#4783) * add sample versions file and update plugin template [skip ci] * uncomment version to prevent build from failing * Apply suggestions from code review Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * [DOCU-2517] App Reg Multiple RGs and DCR - GA release (#4748) * changelog * feat(dcr): how to request with DCR [tdx-2587] (#4716) * feat(dcr): how to request with DCR [tdx-2587] Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> * feat(dcr): change wording [tdx-2587] Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> * feat(dcr): change wording [tdx-2587] Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> * feat(dcr): change wording [tdx-2587] Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> * [TDX-2195] Dev portal app reg with multi-runtime group support (#4473) * feat(runtime-groups): remove section in runtime-groups about dev portal app reg This information is no longer necessary with the availablity of app registration in any runtime group. * feat(enable-app-reg): update bullet about runtime group compatibility * feat(enable-app-reg): add sub-bullets about Gateway versions * feat(app-reg): add runtime group compatibility info * refactor(app-reg): remove redundant info * fix(app-reg): replace Kong Gateway with variable * feat(app-reg): add clarification about default runtime group * feat(app-reg): link back to default runtime group info * feat(app-reg): add section about runtime group differences * refactor(app-reg): update info about OIDC credential claims * chore(app-reg): adjust indentation of Note to ensure it renders properly * fix(app-reg): add article and fix spacing * feat(app-reg): add alpha badges * Revert "feat(app-reg): add alpha badges" This reverts commit 43b0711. * feat(app-reg): add section with badge about alpha stage * fix(app-reg): move badge out of heading * refactor(app-reg): update intro to account for multi-runtime groups * fix(app-reg): move badge below heading * fix(app-reg): remove unnecessary link and overused word * refactor(app-reg): make mode names consistent with other usages * Update app/konnect/dev-portal/applications/enable-app-reg.md Co-authored-by: Andrew Wylde <drewkakes@gmail.com> Co-authored-by: Andrew Wylde <drewkakes@gmail.com> * Apply suggestions from code review Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Update app/konnect/updates.md Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com> Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com> Co-authored-by: Andrew Wylde <drewkakes@gmail.com> Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> * Add a/b test support for the top CTA Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com> Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com> Co-authored-by: yalhyane <y.alhyane@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Philipp Rudloff <philipp.rudloff@konghq.com> Co-authored-by: Michael Heap <m@michaelheap.com> Co-authored-by: Joshua Schmid <joshua.schmid@konghq.com> Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com> Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com> Co-authored-by: Mike Swierenga <mike.swierenga@gmail.com> Co-authored-by: Andrew Wylde <drewkakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the logic from the preview.sh script into the installer.sh script.
Changes the preview.sh script to use the installer.sh script directly with
VERSION=preview.Sets the latest version for the dev docs to
preview(was2.0.0).Fixes broken links to the Kubernetes documentation.
Resolves #960.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com