-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release "dev" shows kumactl 1.5.0 in installation instructions #960
Comments
|
preview.sh would be tricky and messy... The version is extracted from: https://github.com/kumahq/kuma-website/blob/master/docs/docs/dev/versions.json. Maybe we should just have |
After the replatform, the versions file is now located at https://github.com/kumahq/kuma-website/blob/c7d2d266ba3942362a3676cd955bfbdca3a397fc/app/_data/versions.yml. Also, after the replatform, the dev docs use @lahabana Looking at https://kuma.io/preview.sh, you say this is messy because it relies on GitHub CLI, right? In that case, should the dev docs simply show installation instructions without The next question is which direct download URLs we would use. Currently we use the URLs referencing 2.0.0 (e.g. |
For KM the link it should link to a I'm not sure |
@lahabana I think that would work, yes. Are you proposing this to make it so that we can use the same |
This is actually more tricky. In the installation instructions for Docker, we reference the latest version variable several times, for example: kuma-website/app/docs/dev/installation/docker.md Lines 19 to 21 in 78f508a
In general installation instructions, we commonly use the install_os.md snippet with the latest version variable, for example:
We would also need to conditionally switch between the latest version number and the preview version number depending on context here:
With a version marked as Perhaps we can provide the version number in includes like this: {% include snippets/install_os.md version=page.latest_version %}
<!-- or -->
{% include snippets/install_os.md version=page.preview_version %} and use that in the snippet. I’ll play around with that approach. |
I’m stuck on this. It seems that the only reliable kind of version number we should be using for the dev docs is one of the form Using a
We would need to publish images and archives for the |
Other option is to have page.latest_version set at build times by doing the github stuff then? Or doing it as nightly workflow? |
That version would be out-of-date as soon as we publish a new preview version. For the dev docs, that’s perhaps tolerable?
As in rebuilding and redeploying the site every night? That would keep the preview version pretty up-to-date. The choice depends on how precise we want this to be. |
What happened?
The version should probably be the current preview version.
The text was updated successfully, but these errors were encountered: