Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): disabled の説明が不用意に折り返されないように見直し #5132

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Nov 22, 2024

関連URL

概要

disabledDetail で表示されるアイコンが幅によって折り返されないように修正しました。
合わせて、非推奨アイコンの置き換えや高すぎる詳細度を見直しています。

変更内容

確認方法

@uknmr uknmr requested a review from a team as a code owner November 22, 2024 07:32
@uknmr uknmr requested review from yt-ymmt, nabeliwo and TakahiroHimi and removed request for a team November 22, 2024 07:32
Copy link

pkg-pr-new bot commented Nov 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5132

commit: 0bb20a7

@uknmr uknmr enabled auto-merge (squash) November 22, 2024 08:27
@uknmr uknmr force-pushed the fix-Button-disabledDetail branch from 0ac9a12 to 0bb20a7 Compare November 23, 2024 13:51
Copy link
Contributor

@TakahiroHimi TakahiroHimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
折り返されないようになっていることをStorybook上で確認しました

@uknmr uknmr merged commit 5b24fda into master Nov 25, 2024
12 checks passed
@uknmr uknmr deleted the fix-Button-disabledDetail branch November 25, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants