Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslintのwarningを解消する #5117

Merged
merged 34 commits into from
Nov 21, 2024
Merged

fix: eslintのwarningを解消する #5117

merged 34 commits into from
Nov 21, 2024

Conversation

AtsushiM
Copy link
Member

@AtsushiM AtsushiM commented Nov 18, 2024

関連URL

概要

  • eslintのwarningを解決します

変更内容

  • test, storybookのマークアップを修正
  • その他hookの依存関係を整理

確認方法

  • diffを確認する
    • test, storybook用のマークアップの変更であること
    • hookの依存関係からimportした値を取り除いていること
      • 基本的にimportしたものは固定値になるため依存関係に含めても無駄チェックになるだけ

Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5117

commit: 0d9d7bf

@yagimushi yagimushi force-pushed the fix-eslint branch 2 times, most recently from 6f4f108 to e6d502c Compare November 19, 2024 01:22
@AtsushiM AtsushiM changed the title Fix eslint fix: eslint Nov 19, 2024
@AtsushiM AtsushiM marked this pull request as ready for review November 19, 2024 01:41
@AtsushiM AtsushiM requested a review from a team as a code owner November 19, 2024 01:41
@AtsushiM AtsushiM requested review from oti and nabeliwo and removed request for a team November 19, 2024 01:41
@AtsushiM AtsushiM changed the title fix: eslint fix: eslintのwarningを解消する Nov 19, 2024
@yagimushi yagimushi force-pushed the fix-eslint branch 3 times, most recently from 0b8451d to 6ba4f50 Compare November 20, 2024 01:21
Copy link
Contributor

@oti oti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AtsushiM AtsushiM merged commit e5646bf into master Nov 21, 2024
12 checks passed
@AtsushiM AtsushiM deleted the fix-eslint branch November 21, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants