Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ModelessDialog のグラブ領域を修正 #5055

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Oct 25, 2024

関連URL

https://smarthr.atlassian.net/browse/SHRUI-1176

概要

ModelessDialog のダイアログタイトル部ではドラッグできず、テキスト選択になってしまう不具合を修正。

変更内容

既存のスタイルで何故かスタッキングコンテキストを発生させていたことが影響し、ドラッグ対象になっていなかった。

確認方法

Storybook で確認してください。

@uknmr uknmr requested a review from a team as a code owner October 25, 2024 08:00
@uknmr uknmr requested review from misako0927 and nabeliwo and removed request for a team October 25, 2024 08:00
Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5055

commit: a41cf6c

Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@uknmr uknmr merged commit 0635680 into master Oct 28, 2024
12 checks passed
@uknmr uknmr deleted the fix-ModelessDialog-heading-draggable branch October 28, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants