Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppNaviDropdown の deprecated を削除 #5024

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Oct 17, 2024

関連URL

https://smarthr.atlassian.net/browse/SHRUI-1063

概要

buttons を deprecated した際に、DrodownMenuButton への移行を考えていましたが、DropdownMenuButton 内でグルーピングしたいプロダクトが発生したため deprecated を外します。

DropdownMenuButton や AppNaviDropdownMenuButton でグルーピング対応ができるようになったら、また deprecated する予定です。

変更内容

確認方法

ノールックでも問題ないです。

@uknmr uknmr requested a review from a team as a code owner October 17, 2024 22:31
@uknmr uknmr requested review from moshisora and hiroki0525 and removed request for a team October 17, 2024 22:31
Copy link

pkg-pr-new bot commented Oct 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5024

commit: 11a1939

@uknmr uknmr merged commit b8d004e into master Oct 18, 2024
14 checks passed
@uknmr uknmr deleted the fix-AppNaviDropdown-deprecated branch October 18, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants