fix: Loaderの表示遅延処理を削除する #5003
Merged
fix: Loaderの表示遅延処理を削除する #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
remove-loader-defer-display
branch
from
eb687e0 to
46f044f
Compare
commit: |
AtsushiM
requested review from
Qs-F and
masa0527
and removed request for
a team
uknmr
requested changes
Oct 14, 2024
uknmr
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
Why?
表示するタイミングを0.2secずらすことしかできていないちらつきが増加しているのか、減少しているのかがわからないコードになってしまっていたローディング時間がかからない箇所だからLoaderは使わないでおこうという判断は開発者視点でみた場合、行うことはできない変更内容
確認方法