Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

Processing Instruction tokens in Kuchiki #34

Closed
Ygg01 opened this issue Apr 10, 2017 · 5 comments
Closed

Processing Instruction tokens in Kuchiki #34

Ygg01 opened this issue Apr 10, 2017 · 5 comments

Comments

@Ygg01
Copy link
Contributor

Ygg01 commented Apr 10, 2017 •
edited
Loading

From what I understand, @quininer had some troubles adding XML support (see #31 , https://github.com/quininer/sanngaa) to kuchiki. Namely, there are no Processing Instructions token/node in kuchiki, which makes sense, seeing it was made to parse HTML, which doesn't have that token.

Is this something that kuchiki could work around, or should we wait for markup5ever?
@SimonSapin
Copy link
Collaborator

Do you mean processing instructions nodes? I don’t mind taking a PR adding those before the markup5ever refactor.

@Ygg01
Copy link
Contributor Author

Ygg01 commented Apr 10, 2017 •
edited
Loading

I'll try to make a PR soonish.

BTW, how is the markup5ever refactor going and can I help around that?

@SimonSapin
Copy link
Collaborator

Unfortunately it’s not really going, in the sense that @nox and I are both busy with other things.

@SimonSapin
Copy link
Collaborator

@Ygg01 I’ve filed servo/html5ever#266 with a rough plan, in case you want to send PRs :) (Though we might want a branch for this.)

@quininer quininer mentioned this issue Jun 23, 2017
Open
@SimonSapin
Copy link
Collaborator

I will soon archive this repository and make it read-only, so this issue will not be addressed: https://github.com/kuchiki-rs/kuchiki#archived

@SimonSapin SimonSapin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @Ygg01