Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): generate dummy test file for every package #148

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Aug 2, 2023

Description

Ensure that coverage is calculated for every package with Go files, workaround for golang/go#24570

Related issues

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (64f1cd0) 42.59% compared to head (c1d9d37) 17.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #148       +/-   ##
===========================================
- Coverage   42.59%   17.69%   -24.91%     
===========================================
  Files          40      103       +63     
  Lines        3383     9302     +5919     
===========================================
+ Hits         1441     1646      +205     
- Misses       1848     7561     +5713     
- Partials       94       95        +1     

see 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 enabled auto-merge August 2, 2023 10:10
@SOF3 SOF3 disabled auto-merge August 30, 2023 07:43
@SOF3 SOF3 enabled auto-merge August 30, 2023 07:44
@SOF3 SOF3 requested a review from xuqingyun August 30, 2023 07:44
Copy link
Collaborator

@xuqingyun xuqingyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SOF3 SOF3 merged commit 71ffea4 into kubewharf:main Oct 16, 2023
9 checks passed
@SOF3 SOF3 deleted the fix-test-coverage branch October 16, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants