Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Modified error message for invalid pwd and username #918

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PushparajShetty
Copy link

@PushparajShetty PushparajShetty commented Mar 4, 2025

Description of your changes

Fixes #917

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: viskumar <viskumar@guidewire.com>
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.30%. Comparing base (2ab672c) to head (71f00bf).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2ab672c) and HEAD (71f00bf). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2ab672c) HEAD (71f00bf)
apiserver-unittests 1 0
server-e2e-tests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #918       +/-   ##
===========================================
- Coverage   59.01%   48.30%   -10.72%     
===========================================
  Files         116      116               
  Lines       19846    19852        +6     
===========================================
- Hits        11713     9590     -2123     
- Misses       6696     9021     +2325     
+ Partials     1437     1241      -196     
Flag Coverage Δ
apiserver-unittests ?
server-e2e-tests 48.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vibhor Chinda <vibhorchinda@gmail.com>
@PushparajShetty PushparajShetty changed the title [WIP]: Modified error message for invalid pwd and username Fix: Modified error message for invalid pwd and username Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VelaUX displays incorrect error messages for invalid usernames and passwords
1 participant