Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning GIT repo means always getting the bleeding edge of HEAD #77

Open
srjturner opened this issue Jan 3, 2017 · 0 comments
Open

Comments

@srjturner
Copy link

srjturner commented Jan 3, 2017

I had a working process using Kargo / Kargo CLI that has recently broken on "wait for the apiserver to be running". This led me to think about how the CLI is running Kargo itself, and whether that was actually stable. Looking at the code in common.py I see that this is using a Git clone to download Kargo, and of course this means the CLI will always end up using the very latest commits to the master branch of that repo, rather than a specific, known release.

I realise that I can use --noclone and use scripting to first fetch a specific release myself, but the default behaviour feels very obviously brittle to me. I think it should be possible to specify a Kargo release in kargo.yml (via a "kargo_git_tag") and then clone_kargo_git_repo in common.py might do something like git clone -b 'v2.0.0' --single-branch --depth 1 https://github.com/kubespray/kargo.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant