Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Safely Drain a Node” states that you need Kubernetes 1.5 or later #40453

Closed
wsmelton opened this issue Apr 2, 2023 · 10 comments · Fixed by #41092
Closed

“Safely Drain a Node” states that you need Kubernetes 1.5 or later #40453

wsmelton opened this issue Apr 2, 2023 · 10 comments · Fixed by #41092
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@wsmelton
Copy link

wsmelton commented Apr 2, 2023

The PR #23755 improperly set the minim version to 1.5 when there is no such version.

Public link: https://kubernetes.io/docs/tasks/administer-cluster/safely-drain-node/
Markdown file: https://github.com/sftim/kubernetes-website/blob/main/content/en/docs/tasks/administer-cluster/safely-drain-node.md

image

image

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 2, 2023
@kundan2707
Copy link
Contributor

/assign

@kundan2707
Copy link
Contributor

kubernetes 1.5 release end of life (1 October 2017) already passed so this page needs updation

@kundan2707
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 3, 2023
@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Apr 3, 2023

I guess it is mentioned because in v1.5:

[beta] PodDisruptionBudget has been promoted to beta, can be used to safely drain nodes while respecting application SLO's (docs) (kubernetes/enhancements#85)

As per release page

The Kubernetes project maintains release branches for the most recent three minor releases (1.26, 1.25, 1.24). Kubernetes 1.19 and newer receive approximately 1 year of patch support. Kubernetes 1.18 and older received approximately 9 months of patch support.

It totally depends upon the docs and
/sig node
what they want to mention. If it is mentioned because of the time this feature went beta this page might be right.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 3, 2023
@sftim
Copy link
Contributor

sftim commented Apr 3, 2023

/retitle “Safely Drain a Node” states that you need Kubernetes 1.5 or later
/language en

That statement is correct and its inclusion does not, to me, feel misleading.

/priority awaiting-more-evidence

@k8s-ci-robot k8s-ci-robot changed the title Safely Drain a Node “Safely Drain a Node” states that you need Kubernetes 1.5 or later Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Apr 3, 2023
@wsmelton
Copy link
Author

wsmelton commented Apr 3, 2023

Just to confirm the version indicates the complete functionality is not available until v1.5 is released?

PDB is noted released in stable 1.21. Only confusing area is what functionality in the document is for 1.5 and what is available now?

@sftim
Copy link
Contributor

sftim commented Apr 3, 2023

Try this: https://www.google.com/search?q=when+was+kubernetes+1.5+released

The page does not say you need to wait for an upcoming release. I think you have misunderstood what is actually a clear statement @wsmelton.

We could drop the version-check shortcode as we assume everyone is using Kubernetes 1.21 or later.

@tengqm
Copy link
Contributor

tengqm commented Apr 20, 2023

/triage accepted
Drop the version-check would be desireable.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 20, 2023
@mmiranda96
Copy link

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label May 3, 2023
@sftim
Copy link
Contributor

sftim commented May 4, 2023

For SIG Docs, this is only a backlog priority I think. We've other work that we'd want to prioritize.

Help here is still very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants