refactor bootstrap image, bump images #8874

BenTheElder · 2018-07-28T01:10:49Z

use COPY instead of ADD... ADD is more magical
copy create_bazel_cache_rcs.sh into the image
split the entrypoint into a runner for dind + bazel caching, and the actual bootstrap entrypoint
- xref: figure out DinD + podutils #8780, this will let podutils jobs work like: /usr/local/bin/runner.sh my-test-command with env DOCKER_IN_DOCKER_ENABLED. still sorta gross, but it should help us move forward for now. I may refactor further at some point.
make the new runner use the baked in create_bazel_cache_rcs.sh when we don't have a test-infra checkout (so bazel caching should also work in podutils jobs now)

BenTheElder · 2018-07-28T01:11:18Z

/area images
/assign @krzyzacy
I've verified that this at least builds but I haven't tested it at all yet. It should be fine, but we should definitely keep an eye out next time we bump :-)
/hold

krzyzacy · 2018-07-29T04:02:13Z

I guess push and attach a build log from some job that uses the latest image?

BenTheElder · 2018-07-30T16:50:43Z

SGTM, will do that soonish

…

On Sat, Jul 28, 2018 at 9:02 PM Sen Lu ***@***.***> wrote: I guess push and attach a build log from some job that uses the latest image? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8874 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4Bq-I9lNrwfYHPkaIIHJQ_dKzPXeBQks5uLTPGgaJpZM4Vk1v0> .

BenTheElder · 2018-07-30T17:43:27Z

going to rebase onto #8883 and just make this a bump PR as well

BenTheElder · 2018-07-30T19:43:51Z

images/bootstrap/Dockerfile


-ENTRYPOINT ["/workspace/runner"]
+ENTRYPOINT ["/user/bin/entrypoint.sh"]


grrr this should be /usr/bin/entrypoint.sh

dims · 2018-07-30T19:54:19Z

images/bootstrap/runner.sh

+    if [[ -d "./test-infra" ]]; then
+        ./test-infra/images/bootstrap/create_bazel_cache_rcs.sh
+    else
+        /usr/local/bin/create_bazel_cache_rcs.sh | bash


we have to pipe the output into bash? (we don't do this on line 28)

oops, yeah, I initially thought about curl | bash the latest from test-infra but felt terrible about that and did this instead. forgot to drop the pipe to bash 🤦‍♂️

thanks!

dims · 2018-07-30T19:56:11Z

images/bootstrap/entrypoint.sh

+    ./test-infra/jenkins/bootstrap.py \
+        --job="${JOB_NAME}" \
+        --service-account="${GOOGLE_APPLICATION_CREDENTIALS}" \
+        --upload='gs://kubernetes-jenkins/logs' \


should this be configurable? (i remember some jobs have pr-logs or something)

you can specify it again and overwrite it IIRC. I didn't want to touch these flags as this is how they were in the image now. ideally we will phase out using ENTRYPOINT for this and just have some jobs use the runner script + podutils

…r|experimental|releases) (using generate_tests and manual)

BenTheElder · 2018-07-30T22:07:47Z

rebased, fixed the paths, re-bumped

BenTheElder · 2018-07-31T00:19:35Z

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-canary/19553/?log#log
passed with:

Image: gcr.io/k8s-testimages/kubekins-e2e:v20180730-8b7ab3104-master

krzyzacy · 2018-07-31T00:21:18Z

/lgtm
/hold

k8s-ci-robot · 2018-07-31T00:21:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2018-07-31T15:59:16Z

/hold cancel
👀
FYI @cjwagner

BenTheElder · 2018-07-31T16:01:18Z

FYI @neolit123 this is going out now. 🤞

BenTheElder · 2018-07-31T16:18:02Z

uh updateconfig did not run? @krzyzacy @cjwagner

krzyzacy · 2018-07-31T16:41:02Z

hummmmmm

krzyzacy · 2018-07-31T16:45:33Z

missed a hook ?! I cannot find any related logs

I'll work on #8892 now
/shrug

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2018

k8s-ci-robot requested review from ixdy and michelle192837 July 28, 2018 01:10

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2018

k8s-ci-robot assigned krzyzacy Jul 28, 2018

k8s-ci-robot added the area/images label Jul 28, 2018

BenTheElder mentioned this pull request Jul 28, 2018

Fix cos_containerd log dump. #8856

Merged

BenTheElder force-pushed the refactor-bootstrap-runner branch from c458d1d to f0e0e9a Compare July 30, 2018 17:59

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2018

BenTheElder mentioned this pull request Jul 30, 2018

kubeadm-runner: bump the kubernetes-anywhere version #8883

Merged

BenTheElder changed the title ~~refactor bootstrap image~~ refactor bootstrap image, bump images Jul 30, 2018

BenTheElder mentioned this pull request Jul 30, 2018

test-infra blocking presubmits should use stable image tags #8886

Closed

BenTheElder commented Jul 30, 2018

View reviewed changes

dims reviewed Jul 30, 2018

View reviewed changes

BenTheElder force-pushed the refactor-bootstrap-runner branch from f0e0e9a to c1d092c Compare July 30, 2018 20:36

BenTheElder force-pushed the refactor-bootstrap-runner branch from 4902db2 to c3257f6 Compare July 30, 2018 21:01

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2018

refactor bootstrap image runner

eae9bec

BenTheElder force-pushed the refactor-bootstrap-runner branch from c3257f6 to eae9bec Compare July 30, 2018 21:25

bump bootstrap to v20180730-c3257f6c0

8b7ab31

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2018

BenTheElder added 2 commits July 30, 2018 14:31

Bump to gcr.io/k8s-testimages/kubekins-e2e:v20180730-8b7ab3104-(maste…

c8036c3

…r|experimental|releases) (using generate_tests and manual)

Bump to e2e-kubeadm:v20180730-c8036c3a7

fd230a2

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2018

neolit123 mentioned this pull request Jul 31, 2018

Failing Test: [sig-cluster-lifecycle] kubeadm gce, gce-selfhosting up kubernetes/kubernetes#66338

Closed

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2018

k8s-ci-robot merged commit 7a1f0fc into kubernetes:master Jul 31, 2018

BenTheElder mentioned this pull request Jul 31, 2018

updateconfig should have a tool to force re-uploading the entire config #8892

Closed

BenTheElder deleted the refactor-bootstrap-runner branch July 31, 2018 16:30

k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Jul 31, 2018

BenTheElder mentioned this pull request Aug 1, 2018

figure out DinD + podutils #8780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor bootstrap image, bump images #8874

refactor bootstrap image, bump images #8874

BenTheElder commented Jul 28, 2018

BenTheElder commented Jul 28, 2018 •

edited

Loading

krzyzacy commented Jul 29, 2018

BenTheElder commented Jul 30, 2018 via email

BenTheElder commented Jul 30, 2018

BenTheElder Jul 30, 2018

BenTheElder Jul 30, 2018

dims Jul 30, 2018

BenTheElder Jul 30, 2018

BenTheElder Jul 30, 2018

dims Jul 30, 2018

BenTheElder Jul 30, 2018 •

edited

Loading

dims Jul 30, 2018

BenTheElder commented Jul 30, 2018

BenTheElder commented Jul 31, 2018

krzyzacy commented Jul 31, 2018

k8s-ci-robot commented Jul 31, 2018

BenTheElder commented Jul 31, 2018

BenTheElder commented Jul 31, 2018

BenTheElder commented Jul 31, 2018

krzyzacy commented Jul 31, 2018

krzyzacy commented Jul 31, 2018


		ENTRYPOINT ["/workspace/runner"]
		ENTRYPOINT ["/user/bin/entrypoint.sh"]

refactor bootstrap image, bump images #8874

refactor bootstrap image, bump images #8874

Conversation

BenTheElder commented Jul 28, 2018

BenTheElder commented Jul 28, 2018 • edited Loading

krzyzacy commented Jul 29, 2018

BenTheElder commented Jul 30, 2018 via email

BenTheElder commented Jul 30, 2018

BenTheElder Jul 30, 2018

Choose a reason for hiding this comment

BenTheElder Jul 30, 2018

Choose a reason for hiding this comment

dims Jul 30, 2018

Choose a reason for hiding this comment

BenTheElder Jul 30, 2018

Choose a reason for hiding this comment

BenTheElder Jul 30, 2018

Choose a reason for hiding this comment

dims Jul 30, 2018

Choose a reason for hiding this comment

BenTheElder Jul 30, 2018 • edited Loading

Choose a reason for hiding this comment

dims Jul 30, 2018

Choose a reason for hiding this comment

BenTheElder commented Jul 30, 2018

BenTheElder commented Jul 31, 2018

krzyzacy commented Jul 31, 2018

k8s-ci-robot commented Jul 31, 2018

BenTheElder commented Jul 31, 2018

BenTheElder commented Jul 31, 2018

BenTheElder commented Jul 31, 2018

krzyzacy commented Jul 31, 2018

krzyzacy commented Jul 31, 2018

BenTheElder commented Jul 28, 2018 •

edited

Loading

BenTheElder Jul 30, 2018 •

edited

Loading