Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service-catalog is in kubernetes-incubator not kubernetes-sigs #8763

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Jul 20, 2018

/cc @krzyzacy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 20, 2018

this looks like it's slightly off from the logs

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 20, 2018

From the previous run

I0720 20:49:53.737] Root: /go/src/github.com/kubernetes-incubator/service-catalog
I0720 20:49:53.737] cd to /go/src/github.com/kubernetes-incubator/service-catalog
I0720 20:49:53.737] Checkout: /go/src/github.com/kubernetes-incubator/service-catalog/sigs.k8s.io/service-catalog master:9130c341675ac3d1bdb0168da14c9b78a510b9de,2212:1336314da1d7c901350b03544dc5113438be2f80 to /go/src/github.com/kubernetes-incubator/service-catalog/sigs.k8s.io/service-catalog
I0720 20:49:53.738] Call:  git init sigs.k8s.io/service-catalog
I0720 20:49:53.743] Initialized empty Git repository in /go/src/github.com/kubernetes-incubator/service-catalog/sigs.k8s.io/service-catalog/.git/
I0720 20:49:53.743] process 243 exited with code 0 after 0.0m
I0720 20:49:53.743] Call:  git config --local user.name 'K8S Bootstrap'
I0720 20:49:53.746] process 244 exited with code 0 after 0.0m
I0720 20:49:53.746] Call:  git config --local user.email k8s_bootstrap@localhost
I0720 20:49:53.749] process 245 exited with code 0 after 0.0m
I0720 20:49:53.749] Call:  git fetch --quiet --tags https://github.com/kubernetes-sigs/service-catalog master +refs/pull/2212/head:refs/pr/2212

It looks like maybe I shouldn't set the root to the actual path, but to whatever the equivalent of root $GOPATH is.
doesn't look like it does a cd between git init and git fetch, so I'm not sure how this is supposed to work. I'll go find some other logs and try to get a feel for the flow of what happens.

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 20, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2018
@krzyzacy
Copy link
Member

if you want you can look around https://github.com/kubernetes/test-infra/blob/master/jenkins/bootstrap.py#L993 to see what's happening

or else you can switch to podutils :-)

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

podutils I was already working with, and it seems like the right way to go forward. Can I get a dind + podutils? Is there a podutils + kubekins-e2e?

@BenTheElder
Copy link
Member

BenTheElder commented Jul 23, 2018 via email

 - root is not needed as it will do a clone and then cd into it
@MHBauer MHBauer force-pushed the fixup-svc-cat-xbuild branch from 587289a to 144a65c Compare July 23, 2018 23:22
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

/hold cancel
/lgtm

@k8s-ci-robot
Copy link
Contributor

@MHBauer: you cannot LGTM your own PR.

In response to this:

/hold cancel
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

lol, okay @BenTheElder @krzyzacy Can one of you take a look.

@jeremyrickard
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jeremyrickard: changing LGTM is restricted to assignees, and only kubernetes/test-infra repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyrickard, krzyzacy, MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

/shrug

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Jul 23, 2018
@krzyzacy
Copy link
Member

hummmmm, people like @jeremyrickard need to join the org in order to be assigned/lgtm your PRs...

@k8s-ci-robot k8s-ci-robot merged commit 852b81e into kubernetes:master Jul 23, 2018
@k8s-ci-robot
Copy link
Contributor

@MHBauer: Updated the job-config configmap using the following files:

  • key service-catalog-presubmits.yaml using file config/jobs/kubernetes-incubator/service-catalog/service-catalog-presubmits.yaml

In response to this:

/cc @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

@krzyzacy and how about /approve them? we put him in the OWNERS...

@MHBauer MHBauer deleted the fixup-svc-cat-xbuild branch July 23, 2018 23:41
@jeremyrickard
Copy link
Contributor

@krzyzacy should all the people in that OWNERS file join the org? or do we need test-infra people to approve our changes to the svc-cat things?

@fejta
Copy link
Contributor

fejta commented Jul 23, 2018

OWNERS files contain data we control, so there's only a org restriction if we enforce it, which we don't currently.

On the other hand, we will not accept an /lgtm unless the lgtm is from someone who is assigned. And github will not allow us to add someone as an assignee unless they are a repo collaborator.

@krzyzacy
Copy link
Member

/approve probably can work?

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

So close

I0723 23:42:46.748] sed "s/GO_VERSION/1.10/g" < build/build-image/Dockerfile | \
I0723 23:42:46.748]   docker build -t scbuildimage -f - .
W0723 23:42:46.897] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
W0723 23:42:46.899] make[1]: *** [.scBuildImage] Error 1
W0723 23:42:46.899] make: *** [arch-image-amd64] Error 2
W0723 23:42:46.899] Traceback (most recent call last):
W0723 23:42:46.899]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W0723 23:42:46.899]     main(ARGS.env, ARGS.cmd + ARGS.args)
W0723 23:42:46.899]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W0723 23:42:46.900]     check(*cmd)
W0723 23:42:46.900]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W0723 23:42:46.900]     subprocess.check_call(cmd)
W0723 23:42:46.900]   File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
W0723 23:42:46.900]     raise CalledProcessError(retcode, cmd)
W0723 23:42:46.900] subprocess.CalledProcessError: Command '('make', 'images-all', 'svcat-all')' returned non-zero exit status 2
I0723 23:42:46.905] Makefile:201: recipe for target '.scBuildImage' failed
I0723 23:42:46.905] make[1]: Leaving directory '/workspace/github.com/kubernetes-incubator/service-catalog'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants