-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service-catalog is in kubernetes-incubator not kubernetes-sigs #8763
Conversation
this looks like it's slightly off from the logs |
From the previous run
It looks like maybe I shouldn't set the root to the actual path, but to whatever the equivalent of root $GOPATH is. |
/hold |
if you want you can look around https://github.com/kubernetes/test-infra/blob/master/jenkins/bootstrap.py#L993 to see what's happening or else you can switch to podutils :-) |
podutils I was already working with, and it seems like the right way to go forward. Can I get a dind + podutils? Is there a podutils + kubekins-e2e? |
Dind + podutils will be tricky to do reliably because we need dockerd
running somewhere (ideally under a real init).. we probably need an issue
to track sorting that out.
…On Sun, Jul 22, 2018, 20:14 Morgan Bauer ***@***.***> wrote:
podutils I was already working with, and it seems like the right way to go
forward. Can I get a dind + podutils? Is there a podutils + kubekins-e2e?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#8763 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4Bq2-bZWGoQlFH6RCCi3BKInihCyUIks5uJT-WgaJpZM4VZSF8>
.
|
- root is not needed as it will do a clone and then cd into it
587289a
to
144a65c
Compare
/hold cancel |
@MHBauer: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lol, okay @BenTheElder @krzyzacy Can one of you take a look. |
/lgtm |
@jeremyrickard: changing LGTM is restricted to assignees, and only kubernetes/test-infra repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyrickard, krzyzacy, MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/shrug |
hummmmm, people like @jeremyrickard need to join the org in order to be assigned/lgtm your PRs... |
@MHBauer: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@krzyzacy and how about |
@krzyzacy should all the people in that OWNERS file join the org? or do we need test-infra people to approve our changes to the svc-cat things? |
On the other hand, we will not accept an |
|
So close
|
/cc @krzyzacy