service-catalog cross build test with dind #8734
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,37 @@ presubmits: | |
| env: | ||
| - name: NO_DOCKER | ||
| value: "1" | ||
| - name: pull-service-catalog-xbuild | ||
| agent: kubernetes | ||
| context: pull-service-catalog-xbuild | ||
| always_run: true | ||
| skip_report: false | ||
| rerun_command: "/test pull-service-catalog-xbuild" | ||
| trigger: "(?m)^/test (all|pull-service-catalog-xbuild)\\s*" | ||
| labels: | ||
| preset-service-account: "true" | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/k8s-testimages/kubekins-e2e:v20180716-9145034c9-1.10 | ||
| args: | ||
| - "--repo=sigs.k8s.io/$(REPO_NAME)=$(PULL_REFS)" | ||
| - "--root=/go/src/github.com/kubernetes-incubator/$(REPO_NAME)" | ||
| - "--timeout=60" | ||
| - "--scenario=execute" | ||
| - "--" | ||
| - "make" | ||
| - "images-all" | ||
| - "svcat-all" | ||
| env: | ||
| - name: DOCKER_IN_DOCKER_ENABLED | ||
|
There was a problem hiding this comment. I'm going to turn this into a preset soon. Initially we didn't because we wanted to discourage depending on it (I only initially built the support to help us get the rest of our existing jobs onto Prow), but so far it works just fine. This must be paired with an emptyDir volume for the the graph storage (which is remapped There was a problem hiding this comment. What is a preset? I was basing off of, which has preset-service-account It does not have a emptydir, so maybe it's a bad example, oops. There was a problem hiding this comment. searched for There was a problem hiding this comment. preset is something we are mimicing https://kubernetes.io/docs/concepts/workloads/pods/podpreset/ |
||
| value: "true" | ||
| # docker-in-docker needs privileged mode | ||
| securityContext: | ||
| privileged: true | ||
| # docker-in-docker needs a place to store the images | ||
| volumeMounts: | ||
| - name: docker-graph | ||
| mountPath: /docker-graph | ||
| volumes: | ||
| - name: docker-graph | ||
| emptyDir: {} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be github.com/kubernetes-incubator instead of sigs.k8s.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course it should 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followup fix in #8763