Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge nvidia-gpu-device-plugin and nvidia-device-plugin. #19545

Conversation

RamBITS-AI
Copy link
Contributor

@RamBITS-AI RamBITS-AI commented Aug 30, 2024

Fixes #19114.

EDIT:
Merged both the addons, nvidia-gpu-device-plugin and nvidia-device-plugin, into nvidia-device-plugin addon.

BEFORE:

minikube start --driver docker --container-runtime docker --gpus all

PRE-1-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker

minikube status
minikube kubectl -- get pods -A

PRE-1-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker_minikube-status_get-pods

minikube addons enable nvidia-device-plugin --alsologtostderr

PRE-1-minikube-nvidia-device-plugin_addons-enable

minikube addons enable nvidia-gpu-device-plugin --alsologtostderr

PRE-1 1-minikube-nvidia-gpu-device-plugin_addons-enable
PRE-1 2-minikube-nvidia-gpu-device-plugin_addons-enable

AFTER:

minikube start --driver docker --container-runtime docker --gpus all

POST-2 1

minikube status
minikube kubectl -- get pods -A

POST-2 2

minikube addons enable nvidia-device-plugin --alsologtostderr

POST-2 3

minikube addons enable nvidia-gpu-device-plugin --alsologtostderr

POST-2 4

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @RamBITS-AI. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

…plugin.

Removing isKVMDriverForNVIDIA from validations for nvidia-gpu-device-plugin. This is being done to allow merger of functionalities of nvidia-gpu-device-plugin and nvidia-device-plugin into nvidia-gpu-device-plugin. This basically means nvidia-gpu-device-plugin will work for both KVM & non-KVM (including docker) drivers.
Messages, Warnings and In-line Code Comments w.r.t the merger.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2024
Merged nvidia-device-plugin addon into nvidia-gpu-device-plugin addon.
@RamBITS-AI RamBITS-AI marked this pull request as ready for review September 6, 2024 00:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot requested a review from prezha September 6, 2024 00:41
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RamBITS-AI, thanks for the PR! There might have been a miscommunication but nvidia-device-plugin is the addon we want users to be using as it's being kept up to date, nvidia-gpu-device-plugin on the other hand hasn't been updated in 2.5 years, to that's the one we want to deprecate and move users off of.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@RamBITS-AI
Copy link
Contributor Author

Yes, will do @spowelljr.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
@RamBITS-AI RamBITS-AI requested a review from spowelljr December 18, 2024 22:55
@RamBITS-AI
Copy link
Contributor Author

/retest

@RamBITS-AI
Copy link
Contributor Author

/test pull-minikube-build

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

@RamBITS-AI: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-build 1db9a87 link true /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamBITS-AI, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@spowelljr spowelljr merged commit f22b29f into kubernetes:master Dec 19, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advice user to use --gpus instead of gpu-addon on docker driver
5 participants