-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge nvidia-gpu-device-plugin and nvidia-device-plugin. #19545
Merge nvidia-gpu-device-plugin and nvidia-device-plugin. #19545
Conversation
Hi @RamBITS-AI. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Can one of the admins verify this patch? |
Initial Commit.
…plugin. Removing isKVMDriverForNVIDIA from validations for nvidia-gpu-device-plugin. This is being done to allow merger of functionalities of nvidia-gpu-device-plugin and nvidia-device-plugin into nvidia-gpu-device-plugin. This basically means nvidia-gpu-device-plugin will work for both KVM & non-KVM (including docker) drivers.
Messages, Warnings and In-line Code Comments w.r.t the merger.
Merged nvidia-device-plugin addon into nvidia-gpu-device-plugin addon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RamBITS-AI, thanks for the PR! There might have been a miscommunication but nvidia-device-plugin
is the addon we want users to be using as it's being kept up to date, nvidia-gpu-device-plugin
on the other hand hasn't been updated in 2.5 years, to that's the one we want to deprecate and move users off of.
Yes, will do @spowelljr. |
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
Reverting nvidia-gpu-device-plugin to nvidia-device-plugin.
/retest |
/test pull-minikube-build |
@RamBITS-AI: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamBITS-AI, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #19114.
EDIT:
Merged both the addons, nvidia-gpu-device-plugin and nvidia-device-plugin, into nvidia-device-plugin addon.
BEFORE:
minikube start --driver docker --container-runtime docker --gpus all
minikube status
minikube kubectl -- get pods -A
minikube addons enable nvidia-device-plugin --alsologtostderr
minikube addons enable nvidia-gpu-device-plugin --alsologtostderr
AFTER:
minikube start --driver docker --container-runtime docker --gpus all
minikube status
minikube kubectl -- get pods -A
minikube addons enable nvidia-device-plugin --alsologtostderr
minikube addons enable nvidia-gpu-device-plugin --alsologtostderr