Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicbase: Update base image to Ubuntu 22.04 #16069

Merged
merged 8 commits into from
May 17, 2023

Conversation

spowelljr
Copy link
Member

Update the base image of kicbase from Ubuntu 20.04 to 22.04

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@spowelljr spowelljr changed the title WIP: kicbase: update base image to 22.04 kicbase: update base image to 22.04 Mar 17, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 17, 2023
@afbjorklund
Copy link
Collaborator

The xUbuntu_20.04 will also need updating.

@spowelljr
Copy link
Member Author

The xUbuntu_20.04 will also need updating.

Good catch

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2023
@spowelljr spowelljr changed the title kicbase: update base image to 22.04 WIP: kicbase: update base image to 22.04 Apr 10, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 13, 2023
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@medyagh
Copy link
Member

medyagh commented May 10, 2023

@spowelljr can we check manually the ARM and CRIO Docker tests are normal ?
I belive our flake rate is skipping Arm and CRIO

@spowelljr
Copy link
Member Author

@spowelljr can we check manually the ARM and CRIO Docker tests are normal ? I belive our flake rate is skipping Arm and CRIO

arm64 looks good, but CRI-O does look like it's having some problems

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@spowelljr
Copy link
Member Author

/retest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16069) |
+----------------+----------+---------------------+
| minikube start | 52.0s    | 51.6s               |
| enable ingress | 27.1s    | 28.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.7s 25.1s 27.7s 28.2s 27.7s
Times for minikube (PR 16069) ingress: 28.7s 27.6s 28.1s 28.1s 28.7s

Times for minikube start: 52.1s 55.3s 49.2s 52.2s 51.1s
Times for minikube (PR 16069) start: 52.4s 52.2s 52.6s 51.8s 49.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16069) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 23.5s               |
| enable ingress | 21.7s    | 21.2s               |
+----------------+----------+---------------------+

Times for minikube start: 25.2s 24.2s 23.4s 21.8s 21.1s
Times for minikube (PR 16069) start: 24.3s 23.8s 22.4s 24.8s 22.2s

Times for minikube ingress: 21.8s 22.4s 21.9s 20.8s 21.8s
Times for minikube (PR 16069) ingress: 20.9s 21.3s 21.4s 21.4s 20.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16069) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 23.5s               |
| enable ingress | 34.5s    | 37.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.3s 31.3s 31.3s 31.3s 47.3s
Times for minikube (PR 16069) ingress: 31.3s 46.3s 47.4s 31.3s 31.3s

Times for minikube start: 19.9s 23.1s 20.4s 21.1s 23.1s
Times for minikube (PR 16069) start: 23.7s 24.4s 23.3s 23.3s 22.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 0.00 (chart)
KVM_Linux TestNetworkPlugins/group/false/Start (gopogh) 1.84 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/DeployApp (gopogh) 2.45 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 2.45 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/FirstStart (gopogh) 2.45 (chart)
QEMU_macOS TestImageBuild/serial/BuildWithBuildArg (gopogh) 6.21 (chart)
KVM_Linux TestMultiNode/serial/StartAfterStop (gopogh) 11.66 (chart)
QEMU_macOS TestAddons/StoppedEnableDisable (gopogh) 12.96 (chart)
Docker_Linux_crio_arm64 TestPause/serial/SecondStartNoReconfiguration (gopogh) 16.88 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh) 39.87 (chart)

To see the flake rates of all tests by environment, click here.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious can we do Time To K8s on Before and After this PR, including the CPU usage numbers?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr
Copy link
Member Author

spowelljr commented May 17, 2023

Averaged over 5 runs

Run Total Time (seconds) CPU Usage (seconds)
Before 41.5376 4.9772
After 40.1526 5.0144
Diff -1.385 (-3.334%) +0.0372 (+0.747%)

@spowelljr spowelljr merged commit 3631db3 into kubernetes:master May 17, 2023
@spowelljr spowelljr deleted the updateUbuntu22 branch May 17, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants