Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube docker subcommand #9524

Closed
owenthereal opened this issue Oct 22, 2020 · 3 comments
Closed

minikube docker subcommand #9524

owenthereal opened this issue Oct 22, 2020 · 3 comments
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@owenthereal
Copy link

Steps to reproduce the issue:

This is not an issue but a feature request.

It would be nice to have a minikube docker subcommand that shells out to docker with the command's DOCKER_* env vars set to env vars output by minikube docker-env. This is similar to minikube kubectl which runs kubectl against the minikube cluster.

Currently, in order to not to pollute my current shell, I'm running sh -c 'eval $(minikube docker-env) && docker build ...' to self-contain any docker commands against the minikube cluster. This is not as convenient.

Full output of failed command:

N/A

Full output of minikube start command used, if not already included:

N/A

Optional: Full output of minikube logs command:

N/A

@afbjorklund
Copy link
Collaborator

afbjorklund commented Oct 22, 2020

Toyed with the idea, when implementing minikube build (which is pretty much the only thing we use Docker for anyway). But it was disregarded both because "minikube is not a package manager" and that it is easy to install docker (not really true, see #6402)

Another practical problem was that docker is not available for all platforms (no binary for windows anymore), and that we would have to do the same for podman. In the worst case ending up having to build and support moby-engine and podman1-remote ourselves.

See #4868

When running docker-machine, it does have a "config" command matching the "env" command:

But we thought that your current workaround wasn't too much worse than having such a command...

#4868 (comment)

If ignoring the whole idea of providing the client binary for you, I suppose we could implement a "docker-config" and "podman-config" but it would pollute the commands even further. The actual config is also about to get a whole lot smaller soon (ssh).

See #9229

@afbjorklund afbjorklund added co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. labels Oct 22, 2020
@tstromberg tstromberg added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Oct 26, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2021
@spowelljr
Copy link
Member

Closing this for now, if there's more evidence that this should be implemented feel free to comment or reopen issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

6 participants