Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle podman-env in PointToHostDockerDaemon #6886

Closed
medyagh opened this issue Mar 4, 2020 · 1 comment · Fixed by #8062
Closed

handle podman-env in PointToHostDockerDaemon #6886

medyagh opened this issue Mar 4, 2020 · 1 comment · Fixed by #8062
Assignees
@medyagh
Labels
co/podman-driver podman driver issues kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 4, 2020 

	if err := oci.PointToHostDockerDaemon(); err != nil {
		return state.Error, errors.Wrap(err, "point host docker daemon")
	}
@medyagh medyagh added the co/docker-driver Issues related to kubernetes in container label Mar 4, 2020
@medyagh medyagh changed the title oci.PointToHostDockerDaemon() should handle podman-env as well handle podman-env in PointToHostDaemon Mar 4, 2020
@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 4, 2020
@priyawadhwa priyawadhwa added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 4, 2020
@medyagh medyagh added this to the v1.9.0 March 30th milestone Mar 7, 2020
@medyagh medyagh self-assigned this Mar 7, 2020
@afbjorklund
Copy link
Collaborator

Would have been nice to have an "oci" API without requiring the docker daemon concept in the name.

Basically what it wants to do is "env -u", to unset the environment. Not so much "point" to something ?

@afbjorklund afbjorklund changed the title handle podman-env in PointToHostDaemon handle podman-env in PointToHostDockerDaemon Mar 7, 2020
@tstromberg tstromberg removed this from the v1.9.0 March 24th milestone Mar 18, 2020
@tstromberg tstromberg added co/podman-driver podman driver issues and removed co/docker-driver Issues related to kubernetes in container labels Mar 18, 2020
@afbjorklund afbjorklund mentioned this issue May 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medyagh medyagh

Labels
co/podman-driver podman driver issues kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a PointToHost function for podman as well afbjorklund/minikube
4 participants
@tstromberg @medyagh @afbjorklund @priyawadhwa