Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for virtualbox DNS settings #4636

Closed
medyagh opened this issue Jun 28, 2019 · 3 comments
Closed

Add documentation for virtualbox DNS settings #4636

medyagh opened this issue Jun 28, 2019 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Jun 28, 2019 •
edited
Loading

We need to document the options added by PR #4619 by @cvila84 for virtualbox DNS settings in the docs
--dns-proxy and
--host-dns-resolve
@medyagh medyagh added kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 28, 2019
@cvila84
Copy link
Contributor

cvila84 commented Jun 29, 2019

I can help. I took a look to https://github.com/kubernetes/minikube/tree/master/docs but it is not very clear to me what we can document here regarding start options

@cvila84
Copy link
Contributor

cvila84 commented Jul 1, 2019

#4647 adds a new cli_commands.md, maybe we can document here once the PR is merged ?

@tstromberg
Copy link
Contributor

The documentation isn't pretty, but https://minikube.sigs.k8s.io/docs/reference/commands/start/ now includes these flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstromberg @medyagh @cvila84