Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const DefaultDiskSize is Defined But Not Implemented for All Drivers #3530

Closed
barry8schneider opened this issue Jan 14, 2019 · 3 comments
Closed

Const DefaultDiskSize is Defined But Not Implemented for All Drivers #3530

barry8schneider opened this issue Jan 14, 2019 · 3 comments

Comments

@barry8schneider
Copy link

barry8schneider commented Jan 14, 2019 •
edited
Loading

The const DefaultDiskSize is defined but implemented for all drivers. Is this constant used if no driver is specific? Please implement. Thanks
@barry8schneider barry8schneider changed the title Const DefaultDiskSize Never Used In Code Const DefaultDiskSize is Defined But Never Used In Project Jan 14, 2019
@Zyqsempai
Copy link
Contributor

@barry-schneider Actually, it's used https://github.com/kubernetes/minikube/search?q=DefaultDiskSize&unscoped_q=DefaultDiskSize

@barry8schneider
Copy link
Author

I will update the questsion

@barry8schneider barry8schneider changed the title Const DefaultDiskSize is Defined But Never Used In Project Const DefaultDiskSize is Defined But Not Emplemented for All Drivers Jan 14, 2019
@barry8schneider barry8schneider changed the title Const DefaultDiskSize is Defined But Not Emplemented for All Drivers Const DefaultDiskSize is Defined But Not Implemented for All Drivers Jan 14, 2019
@Zyqsempai
Copy link
Contributor

Ok, i will take care of it.

@Zyqsempai Zyqsempai mentioned this issue Jan 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barry8schneider @Zyqsempai