Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Auth addons appears to cause CSI addon test failures #12472

Closed
sharifelgamal opened this issue Sep 14, 2021 · 1 comment · Fixed by #12473
Closed

GCP Auth addons appears to cause CSI addon test failures #12472

sharifelgamal opened this issue Sep 14, 2021 · 1 comment · Fixed by #12473
Assignees
@sharifelgamal
Labels
addon/gcp-auth Issues with the GCP Auth addon kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
1.24.0

Comments

@sharifelgamal
Copy link
Collaborator

Based on the gopogh report on failing CSI tests, it seems like disable GCP auth is causing confusion with the service account's image pull secret.

https://storage.googleapis.com/minikube-builds/logs/master/20399/Docker_Linux.html#fail_TestAddons%2fparallel%2fCSI
@sharifelgamal sharifelgamal added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. addon/gcp-auth Issues with the GCP Auth addon labels Sep 14, 2021
@sharifelgamal sharifelgamal added this to the 1.24.0 milestone Sep 14, 2021
@sharifelgamal sharifelgamal self-assigned this Sep 14, 2021
@sharifelgamal sharifelgamal mentioned this issue Sep 14, 2021
Merged
@sharifelgamal
Copy link
Collaborator Author

This is partially what I fixed in #12473 and partially a race condition built into the addon test itself. The solution is to make the CSI and GCP Auth tests run serially so they don't interfere with each other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharifelgamal sharifelgamal

Labels
addon/gcp-auth Issues with the GCP Auth addon kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

make sure to delete image pull secrets on gcp auth addon disable sharifelgamal/minikube
1 participant
@sharifelgamal