minikube start should wailt till "download-only" is finishing

[medyagh]

we could use our lock package https://github.com/kubernetes/minikube/tree/master/pkg/util/lock

to put a lock when minikube start --download-only happens

and then when minikube start runs when this lock exists will Wait for it to finish up to a reasonable time

[afbjorklund]

I'm confused. You mean that minikube start exits currently, before the downloads have been completed ?

Or is this when running two minikube start at the same time, both using the same kubernetes version ?

[andriyDev]

The latter. When running two instances of minikube start, only one image should be downloaded.

The original issue involved only locking when --download-only was involved, but perhaps this should be more generic and apply to any minikube start.

[afbjorklund]

Good thing, we had some other corruption of the downloaded images so I was starting to question everything :-)
(it was due to our download code not checking the checksum, before adding a resumed download to the cache)

[medyagh]

/assign @andriyDev